Vite does not load proper build (server) on ssr webworker build

Open
#153 5 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript, vite
Domain
build-system

Research direction

Reproduce the SSR webworker build with the provided Vite configuration, first checking how the plugin passes ssr.target and resolve.conditions into dependency resolution. Compare the output with and without the shown aliases; done when the server builds select the correct Solid builds without manual aliases.

Written by the indexing model from the issue text.

Description

While building the ssr bundle with ssr.target = "webworker", it looks like the default web builds of vite is being bundled. I have these in my vite config but it is no help.

resolve: {
  conditions: ["worker", "webworker"],
},

Only when I add aliases to correct builds, then it works:

resolve: {
  conditions: ["worker", "webworker"],
  alias: {
    "solid-js/web": "solid-js/web/dist/server",
    "solid-js": "solid-js/dist/server",
  },
},

Here's my complete config:

Details 

{
  appType: "custom",
  resolve: {
    conditions: ["worker", "webworker"],
    alias: {
      "solid-js/web": "solid-js/web/dist/server",
      "solid-js": "solid-js/dist/server",
    },
  },
  build: {
    outDir: "dist",
    manifest: false,
    chunkSizeWarningLimit: 1024 * 1024,
    emptyOutDir: false,
    ssrEmitAssets: false,
    copyPublicDir: false,
    assetsDir: ".worker",
    rollupOptions: {
      input: "virtual:worker-entry",
      output: {
        entryFileNames: "_worker.js",
        inlineDynamicImports: false,
      },
    },
    ssr: true,
  },
  ssr: {
    target: "webworker",
    noExternal: true,
  },
};
Dominant language
TypeScript
Stars
520
Forks
70
Avg merge
23h 35m
Merged PRs (30d)
39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from solidjs/solid-vite-plugin

All issues in solidjs/solid-vite-plugin

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.