Compaction with mandated context incompatible with OIDC

Open
#201 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale

Research direction

Start with the mandated JSON-LD context linked in the issue and the Client ID Document example in section 5.1. Reproduce the expand-and-compact result in the JSON-LD Playground, then verify that the context produces OIDC Dynamic Registration-compatible redirect_uris syntax.

Written by the indexing model from the issue text.

Description

While experimenting in the JSON-LD Playground, I stumbled upon the following issue, which I could only solve by diverting from the mandated JSON-LD context.

Starting from the example Client ID Document in 5.1, when expanding with the context and then compacting the result again, the "redirect_uris": ["https://app.example/callback"] statement becomes:

"redirect_uris": {
    "@none": [
        "https://app.example/callback"
    ]
}

This is obviously not what we want, in order to be compatible with OIDC Dynamic Registration syntax. It is due to redirect_uris being configured as a JSON-LD ID Map in the context, as follows.

"redirect_uris": {
    "@id": "oidc:redirect_uris",
    "@type": "@id",
    "@container": [
        "@id",
        "@set"
    ]
}

That data structure is meant for maps, both the key and the value of which are (named) nodes. A set of redirect URIs, however, is just a set of nodes, not a map. I therefore believe the @id annotation of @container should be removed, leaving just "@container": "@set", which results in the correct expansion.

Dominant language
Bikeshed
Stars
26
Forks
14
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from solid/solid-oidc

All issues in solid/solid-oidc

Similar issues

More Security issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.