Allow disabling or configuring of websocket's 10-second heartbeat timeout
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, nodejs
- Domain
- backend, networking
Research direction
Start at src/trans-websocket.coffee around line 99, where the hardcoded 10-second heartbeat timer is described. Compare the timeout configuration used by the xhr-based transports, including disconnect_delay, and determine how a setting could disable or configure this timeout while preserving the current default behavior.
Written by the indexing model from the issue text.
Description
The websocket transport has a hardcoded 10 second timer:
If the websocket is sending a large message over a slow link to the client, then it may take more than 10 seconds for the heartbeat to actually arrive. A big improvement would be to wait until the heartbeat is actually sent to start the timer, but even then, the client may have large messages it's sending to the server too, which a heartbeat response would be queued behind.
I'm not necessarily asking for a change to the default behavior, but it would be great to be able to disable or configure this timeout, like disconnect_delay for the xhr-based transports.
(If you like I can put together a PR for this, but I wanted to first ask if such a patch would be welcome.)
- Dominant language
- JavaScript
- Stars
- 2.1k
- Forks
- 306
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sockjs/sockjs-node
-
CVE issues (uuid)Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
sockjs/sockjs-node#329 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
sockjs/sockjs-node#316 · 14 comments · 26 reactions ·
-
Is prefix a must?Open
Difficulty 3/5 1-2 days Newbie friendliness 30/100
sockjs/sockjs-node#311 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
sockjs/sockjs-node#304 · 2 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
sockjs/sockjs-node#301 ·
All issues in sockjs/sockjs-node
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
daisy/a11y-meta-viewer#18 ·
-
good first issue status: needs triaging type: bug version: 2.0
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
medusajs/medusa#17094 · 2 comments ·
Maintainers usually reply within 1 day
-
browser: chrome package: @carbon/react package: styles
Difficulty 1/5 Under an hour Newbie friendliness 92/100
carbon-design-system/carbon#23567 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
clerk/javascript#10033 ·
Maintainers usually reply within 1 day
-
bug client p1
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vercel/eve#4173 · 2 comments ·
Maintainers usually reply within 1 day