Skip Lite: views re-exported through a non-Skip umbrella target are silently dropped in @ViewBuilder

Open
#753 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
22/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
kotlin, swift

Research direction

Start with the repro repo and run swift package --allow-writing-to-package-directory skip-transpile on UsesUmbrella versus UsesDirect to compare the generated DemoView.kt. The relevant code is in SkipTranspile.swift (the umbrella-skipping logic around lines 204-221), CodebaseInfo.swift (expandWithExportedImports and rankScore), and KotlinSwiftUITransformer.swift (translateViewBuilder and translateFunctionCall). Done means Badge gets .Compose(composectx) and Card's trailing closure is wrapped in ComposeBuilder when imported through the umbrella, with the output matching the direct import.

Written by the indexing model from the issue text.

Description

Some of our packages use a thin umbrella target (no Skip/skip.yml) whose only content is @_exported import Core, so that consumers can import CoreUmbrella. A Skip module that imports the umbrella gets broken Kotlin for any Core view used inside a @ViewBuilder:

  • Badge() is emitted without .Compose(composectx), so it never renders.
  • Card { Text("a"); Text("b") } becomes a plain lambda, so only the last child survives and Card itself is not composed.

Swift, the transpile and Kotlin all compile without errors. The only sign is a generic "Skip is unable to match this API call" warning, and it only appears when the file is re-transpiled.

Skip 1.9.19, skip-ui 1.64.0, skip-foundation 1.4.8. The code involved is unchanged on main.

Repro

https://github.com/daniboybye/skip-umbrella-viewbuilder-repro

// Inner (Skip module):     public struct Badge: View, public struct Card<Content: View>: View { init(@ViewBuilder content:) }
// InnerUmbrella (no skip.yml):
@_exported import Inner

// UsesUmbrella (Skip module); UsesDirect is identical but uses `import Inner`
import InnerUmbrella
import SwiftUI

public struct DemoView: View {
    public var body: some View {
        VStack {
            Badge()
            Card { Text("a"); Text("b") }
        }
    }
}
swift package --allow-writing-to-package-directory skip-transpile

Generated DemoView.kt, UsesDirect → UsesUmbrella:

-                    Badge().Compose(composectx)
+                    Badge()
                     Card { ->
-                        ComposeBuilder { composectx: ComposeContext ->
-                            Text(LocalizedStringKey(stringLiteral = "a")).Compose(composectx)
-                            Text(LocalizedStringKey(stringLiteral = "b")).Compose(composectx)
-                            ComposeResult.ok
-                        }
-                    }.Compose(composectx)
+                        Text(LocalizedStringKey(stringLiteral = "a"))
+                        Text(LocalizedStringKey(stringLiteral = "b"))
+                    }

Cause

  1. The plugin recurses through InnerUmbrella, skips it because it has no skip.yml, and still links Inner (SkipTranspile.swift#L204-L221). So Inner's symbols are loaded, but skipstone never learns that InnerUmbrella re-exports Inner.
  2. expandWithExportedImports only follows re-exports declared by Skip modules (skiptools/skipstone#256). Inner is therefore not visible to the file, and rankScore returns 0 for Badge and Card.
  3. With no API match, translateViewBuilder adds no .Compose, and translateFunctionCall doesn't treat the trailing closure as a @ViewBuilder.

It goes unnoticed when Inner's skip.yml sets package: to the name derived from the umbrella (inner.umbrella), because import inner.umbrella.* then resolves. That is our setup.

Workaround

import InnerUmbrella
#if SKIP
import Inner
#endif

Calling the view through a local function (func badge() -> some View { Badge() }) also works for plain views, but not for @ViewBuilder containers.

Proposed fix

  • skip plugin: for a dependency target without skip.yml, pass --umbrella-module InnerUmbrella:<dir> and add its sources to the plugin inputs.
  • skipstone: parse those files, collect their @_exported imports of linked modules, and register a symbol-less ModuleExport for the umbrella with those exportedModuleNames. The #256 code handles the rest. Also skip the umbrella's own Kotlin import unless it matches a real package.

A local skipstone test confirms that adding such a stand-in ModuleExport restores both .Compose calls with no other change.

Separately, it would help if an unmatched bare initializer inside a @ViewBuilder produced a clearer diagnostic, since its result is silently discarded.

If this direction works for you, I'm happy to send PRs for skip and skipstone.

Dominant language
Swift
Stars
3.3k
Forks
115
Avg merge
1d 15h
Merged PRs (30d)
5

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from skiptools/skip

All issues in skiptools/skip

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.