Remove dependency on Firebase Messaging
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- android, firebase, swift
- Domain
- mobile-dev
Research direction
Start by inspecting Sources/SkipNotify/Skip/skip.yml at the cited dependency line and reading the referenced ninja-chat commit. Trace how push notifications are currently wired and identify the device service boundary described in the issue. Done means Firebase Messaging is no longer required while push support remains functional and the design can accommodate non-GMS services.
Written by the indexing model from the issue text.
Description
Currently, we depend on Firebase Messaging for handling push notifications: https://github.com/skiptools/skip-notify/blob/3ad44e165defe435cf6d618d9fe985d76ea40e02/Sources/SkipNotify/Skip/skip.yml#L24C28-L24C66
- 'implementation("com.google.firebase:firebase-messaging")'
But this dependency could be removed if we instead interface directly with the "com.google.android.gms" service on the device (if present), like was done at https://github.com/christianrowlands/ninja-chat/commit/1abb22b542343642aacb4f7bd82f0bb2bc380ea4
This opens the possibility of supporting devices that do not have Google Mobile Services available (AOSP builds, Chinese ROMs and other non-Android Certified devices, etc.), as well as enabling flexible support for multiple notification services (as discussed in https://github.com/skiptools/skip-notify/issues/2).
- Dominant language
- Swift
- Stars
- 6
- Forks
- 1
- Avg merge
- 17m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from skiptools/skip-notify
-
enhancement help wanted
Difficulty 5/5 Over a week Newbie friendliness 25/100
skiptools/skip-notify#2 · 2 comments · 1 reaction ·
All issues in skiptools/skip-notify
Similar issues
-
area/kotlin
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
cable-report
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
darrylmorley/whatcable#656 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
omlahore/RemoveMacAI#67 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
521xueweihan/HelloGitHub#4049 ·
-
[quality] macOSScreenshotLocation(): configured-location branch (ScreenshotFiles.swift:30) never executes under swift testPossibly taken @arteeh claimed this today. Openagent/quality agent/reviewer help wanted kind/test stage/040-covered-by-pr testing
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
hivecommons/hotshot#249 · 4 comments ·
Maintainers usually reply within 1 day