Htpasswd should not enforce the uid attribute

Open
#13 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
php

Research direction

Start in src/Auth/Source/Htpasswd.php around line 100 and compare the current uid enforcement with the linked SimpleSAMLphp attribute NameFormat documentation. Determine how the attribute name should be made configurable, then verify that authentication can use the configured name without forcing uid.

Written by the indexing model from the issue text.

Description

The Htpasswd currently enforces the username to the uid attribute.

https://github.com/simplesamlphp/simplesamlphp-module-authcrypt/blob/689b2ee5975c81a451aa03672bc93cfff2be7e6c/src/Auth/Source/Htpasswd.php#L100

Ideally this attribute should be user configurable.

The documentation recommends to use urn:oasis:names:tc:SAML:2.0:attrname-format:uri for attribute's NameFormat but forcing the attribute name to uid goes against this.

Dominant language
PHP
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.