Worker CEB-scale gate tests need a work budget, not only counts

Open Beginner friendly
#237 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
69/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
testing

Research direction

Start with the CEB-scale Worker gate tests for EntryDuplicate and AlloRepeatedForm, then read the query snapshot test that limits SQL statements to at most three. Add a statement or rows-read budget to each gate test so excessive work fails there; done means both tests enforce a work budget alongside their result counts.

Written by the indexing model from the issue text.

Description

Follow-up to #230 (landed in 8f9f7b50c). The CEB-scale Worker checks for EntryDuplicate and AlloRepeatedForm now assert result counts in the gate, and their timing moved to SlowScale. The in-gate tests have no work budget, though: no bound on statements or rows read. A quadratic regression would pass the gate and show up only when someone runs SlowScale.

Next: give each test a budget on statements or rows, as the query snapshot test does (at most 3 SQL statements).

Dominant language
C#
Stars
1
Forks
0
Avg merge
4h 3m
Merged PRs (30d)
66

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sillsdev/motif

All issues in sillsdev/motif

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.