Readiness: invalid-shape words unchanged by a Proposal should not make evidence Incomplete
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Read the Readiness ADR and trace how TrialReviewEvidence and ReviewCaseClassifier handle InvalidShape evidence before and after a change. Add a test for a word with the same invalid shape and reason in both results, and verify it remains listed in the Review without making Readiness refuse. The issue does not name test or ADR file paths, so locate them in the repository first.
Written by the indexing model from the issue text.
Description
Readiness refuses apply --autonomous when a Trial word has invalid-shape evidence, even when that word refused the same way before and after the change, so the change cannot have affected it.
Found on the CEB Note sweep: a Notes-only Proposal of 4,139 setNotes edits (PR #109). Its Trial covers the edited segments' wordforms, and the parser refuses Don’t (U+2019) and v2 with InvalidShape. Those characters aren't in the Cebuano phoneme inventory. TrialReviewEvidence turns that into invalid-evidence, which leaves Correctness Incomplete, so Readiness refuses. Any Trial whose words include such wordforms hits the same thing, the Default Selection included.
Proposed rule: a word whose before and after evidence are both InvalidShape, for the same reason, counts as unaffected, not incomplete. It is still listed in the Review, but it doesn't block Readiness. This applies to every Proposal, not only Notes-only ones.
Workaround meanwhile: run the Trial with --words, leaving those words out. That is valid for a Notes-only change.
Next: decide the rule in the Readiness ADR, then make a small change in ReviewCaseClassifier or Readiness, with a test.
🤖 Generated with Claude Code
- Dominant language
- C#
- Stars
- 1
- Forks
- 0
- Avg merge
- 3h 55m
- Merged PRs (30d)
- 36
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sillsdev/motif
-
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day
-
Playground selection bar: comes back after Apply or scrolling while focus is in the Markdown paneOpentextediting
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
textediting
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
textediting
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Maintainers usually reply within 1 day
-
textediting
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
bug emitter:client:csharp
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
microsoft/typespec#12572 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
needs-area-label
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
AWS Lambda: KeyNotFoundException drops HTTP-triggered transactions when allowAllHeaders is disabledOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
newrelic/newrelic-dotnet-agent#3949 · 1 comment ·
Maintainers usually reply within 1 day
-
area-networking
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/aspnetcore#70545 · 1 comment ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100