GDR preview formatting: known limits from the PR #117 review

Open
#118 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
tooling

Research direction

Read the three known limits in the issue alongside GdrDiscussion.cs around line 59 and the B/I/U toggle implementation. First determine which behaviors are intended for this preview and which should change before release; the issue leaves those decisions open. Done means making the agreed link-property, style-toggle, or style-loading behavior deliberate and checking each affected behavior.

Written by the indexing model from the issue text.

Description

textediting
  • _linkProps is keyed by ObjData with TryAdd (GdrDiscussion.cs ~59): a new link to a record the Discussion already links to takes the existing link's stored properties. Harmless today; make it deliberate (per run) when links get their own formatting.
  • B/I/U toggles look only at explicit run properties: text bold through a character style (e.g. Strong) can't be made un-bold; each click adds/removes an explicit 'on' (copied from the playground). Decide whether toggles should consult the resolved style.
  • gdr show now returns every project style × every writing system per record click (fine for the preview; consider caching or lazy styles before release).
Dominant language
C#
Stars
1
Forks
0
Avg merge
3h 55m
Merged PRs (30d)
36

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sillsdev/motif

All issues in sillsdev/motif

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.