Flaky under load: LanguageReviewFixTests 'keeps cancelling ... asked a few times, not for ever'

Open
  • Is something wrong?
#145 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

A pull request for this has already been merged.

  • #149 by @johnml1135 — merged

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
testing

Research direction

Start with LanguageReviewFixTests, especially A_service_that_keeps_cancelling_what_nobody_cancelled_is_asked_a_few_times_not_for_ever, and read AGENTS.md for the constraint against wall-clock assertions. Reproduce the failure under parallel load and trace the timing dependency in the test or behavior. Done means the test is deterministic under load without wall-clock assertions; a linked merged PR (#149) indicates this work has already been completed.

Written by the indexing model from the issue text.

Description

A_service_that_keeps_cancelling_what_nobody_cancelled_is_asked_a_few_times_not_for_ever failed once on net48 Release under heavy parallel load (seen while building PR #142). Find the timing dependency and make it deterministic (AGENTS.md: no wall-clock assertions).

Dominant language
C#
Stars
0
Forks
0
Avg merge
1h 43m
Merged PRs (30d)
43

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sillsdev/SIL.TextEditing

All issues in sillsdev/SIL.TextEditing

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.