Markdown reader: lone-marker list after a blank line, star emphasis across lines, Markdig slow paths

Open
  • Is something wrong?
#126 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend

Research direction

Start by reading the Markdown reader and its tests for list markers and emphasis across line breaks; compare the reported examples with Pandoc behavior and the existing handling of +. Then investigate how Markdig handles the repeated-link, large-table, and deep-list inputs. Done means the reported cases are handled or reported as requested, with hostile-input slow paths considered; the issue does not name files or tests.

Written by the indexing model from the issue text.

Description

From the final PR #73 review (no text is lost in either case; structure differs from Pandoc with no finding):

  • A lone list marker followed by marker-and-text lines after a blank line (Text⏎⏎-⏎- b, also * and 1.) reads as one text paragraph - - b, while Pandoc reads an empty item and item b. Read it as a list, or report it as + already is.
  • Text⏎*⏎* b stays text, while Pandoc reads emphasis across the line break. Report it.
    Also noted in the review rounds: Markdig's own slow paths on hostile input ([a]( repeated 32K times ≈ 4 s, very large tables, deep lists) are not guarded; consider input-size limits.
Dominant language
C#
Stars
0
Forks
0
Avg merge
1h 43m
Merged PRs (30d)
43

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sillsdev/SIL.TextEditing

All issues in sillsdev/SIL.TextEditing

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.