Make double-click tests deterministic instead of retrying

Open
  • Is something wrong?
#125 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
67/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp
Domain
testing

Research direction

Start by reading the double-click helper changed in PR #122 and the double-click cases in SelectionTests. Check how the tests currently trigger pointer clicks and where Avalonia's click count is determined, then choose a test seam that lets them specify the count. Done when the SelectionTests double-click cases are deterministic and the retry is removed.

Written by the indexing model from the issue text.

Description

Double-click tests depend on Avalonia counting clicks by real time (the system double-click interval), so on a busy CI runner two presses become two single clicks. PR #122 added a retry (up to 5 attempts) to one helper; the SelectionTests double-click tests use the same timing and can flake. Make click counting deterministic in tests (pass ClickCount through a test seam or raise pointer events with an explicit click count) and remove the retry.

Dominant language
C#
Stars
0
Forks
0
Avg merge
1h 43m
Merged PRs (30d)
43

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sillsdev/SIL.TextEditing

All issues in sillsdev/SIL.TextEditing

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.