Add strong background tokens for status colors
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 54/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- design
Research direction
Start with the strong appearance styles in mt-announcement, including the TODO-marked attention and positive colors. Review the existing light and dark color tokens and contrast requirements, then check mt-brand, mt-nav, mt-switch, mt-radio-group and mt-data-table for backgrounds using icon tokens. Done means adding the requested background and foreground tokens, using them in mt-announcement, removing its TODO and deciding whether the listed components need the new tokens.
Written by the indexing model from the issue text.
Description
Components that fill a surface with a status color have no background token for it. They borrow icon or interaction tokens instead, which ties the background to tokens with another purpose: a change to an icon color would change these backgrounds too.
Where it shows
mt-announcementwithappearance="strong"(onfeat/add-mt-announcement, #1494):attentionuses--color-icon-attention-default,positiveuses--color-icon-positive-default, both marked with a TODOinfouses--color-interaction-primary-default,criticaluses--color-interaction-critical-defaultandneutraluses--color-elevation-surface-floating
- Other places that fill a background with an icon token:
mt-brand, the active marker ofmt-nav,mt-switch,mt-radio-groupandmt-data-table. Worth checking whether they need the same tokens.
To do
- Add strong background tokens for neutral, brand, attention, critical and positive, for light and dark
- Add the text and icon tokens that go on them, with enough contrast (white on today's brand blue is 4.4:1)
- Use them in
mt-announcementand remove the TODO - Check the other places above
- Dominant language
- TypeScript
- Stars
- 37
- Forks
- 24
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 24
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from shopware/meteor
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
package: components
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
area/accessibility
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
package: components priority/low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vega/vega-webgpu#40 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
openwatersio/slackwater#550 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug size:small
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
fb55/htmlparser2#2579 ·
Maintainers usually reply within 1 day