Add strong background tokens for status colors

Open
#1,507 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
54/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
design

Research direction

Start with the strong appearance styles in mt-announcement, including the TODO-marked attention and positive colors. Review the existing light and dark color tokens and contrast requirements, then check mt-brand, mt-nav, mt-switch, mt-radio-group and mt-data-table for backgrounds using icon tokens. Done means adding the requested background and foreground tokens, using them in mt-announcement, removing its TODO and deciding whether the listed components need the new tokens.

Written by the indexing model from the issue text.

Description

Components that fill a surface with a status color have no background token for it. They borrow icon or interaction tokens instead, which ties the background to tokens with another purpose: a change to an icon color would change these backgrounds too.

Where it shows

  • mt-announcement with appearance="strong" (on feat/add-mt-announcement, #1494):
    • attention uses --color-icon-attention-default, positive uses --color-icon-positive-default, both marked with a TODO
    • info uses --color-interaction-primary-default, critical uses --color-interaction-critical-default and neutral uses --color-elevation-surface-floating
  • Other places that fill a background with an icon token: mt-brand, the active marker of mt-nav, mt-switch, mt-radio-group and mt-data-table. Worth checking whether they need the same tokens.

To do

  • Add strong background tokens for neutral, brand, attention, critical and positive, for light and dark
  • Add the text and icon tokens that go on them, with enough contrast (white on today's brand blue is 4.4:1)
  • Use them in mt-announcement and remove the TODO
  • Check the other places above
Dominant language
TypeScript
Stars
37
Forks
24
Avg merge
3d 7h
Merged PRs (30d)
24

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from shopware/meteor

All issues in shopware/meteor

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.