Button: define a pressed/open state for triggers of dropdowns, menus and popovers
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start by reading the mt-button implementation and its button docs, especially the "States" section; the issue does not name file paths or tests. Then inspect mt-context-button and the mt-popover trigger to understand how open state is represented. Done means all button variants can show a persistent open state, the triggers set the specified ARIA attributes, and the docs and a story cover its use.
Written by the indexing model from the issue text.
Description
Package(s)
@meteor/component-library
Current Situation
mt-button has no state for a button that stays pressed because it opened something that is still open (dropdown, action menu, popover, toggle). It snaps back to default on pointer release while the menu is still visible.
The --color-interaction-*-pressed tokens exist but are only used by the tertiary variant, and only for :active. There is no aria-expanded / aria-pressed handling, and the button docs do not mention such a state.
Proposed Improvement
- Add a persistent pressed/open state to
mt-buttonthat uses the pressed tokens for all variants and is distinct from hover and focus. - Set
aria-expandedfor menu triggers andaria-pressedfor toggles. - Let
mt-context-buttonand themt-popovertrigger apply the state automatically while open. - Document when to use it in the "States" section of the button docs and add a story.
- Dominant language
- TypeScript
- Stars
- 37
- Forks
- 24
- Avg merge
- 6d 49m
- Merged PRs (30d)
- 16
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from shopware/meteor
-
area/accessibility
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 6 days
-
package: components priority/low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 6 days
-
priority/low
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 6 days
-
priority/low
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 6 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
umami-software/umami#4637 ·
Maintainers usually reply within 3 days
-
Hotkeys fire when pressed with the Ctrl key, so browser shortcuts also trigger player actionsPossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
muxinc/media-chrome#1332 ·
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
polarsource/polar#15580 ·
Maintainers usually reply within 1 day
-
accepted bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
pingdotgg/t3code#20931 · 1 comment ·
Maintainers usually reply within 1 day
-
bug/1-unconfirmed kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day