Avoid parsing to non-finite floating point numbers

Open
#167 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
css, rust
Domain
web-dev

Research direction

Use the 3E833 case from #165 as the starting input and inspect the Token::Number parsing and serialization paths. Determine whether the intended completion is to reject non-finite token values, prevent inf serialization, or both; done means the chosen behavior is covered for this input.

Written by the indexing model from the issue text.

Description

In #165, this input 3E833 is parsed as a Token::Number whose value is std::f32::INFINITY, which serializes as inf.

We should definitely not serialize any number as inf (maybe an arbitrary large number instead), but probably also avoid non-finite numbers in tokens in the first place.

CC https://github.com/servo/servo/issues/15729

Dominant language
Rust
Stars
869
Forks
152
Avg merge
15h 8m
Merged PRs (30d)
12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from servo/rust-cssparser

All issues in servo/rust-cssparser

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.