Merge style_traits::ToCss trait into cssparser::ToCss
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start by comparing cssparser/src/serializer.rs#L14 with stylo/style_traits/values.rs#L78 to identify the differences between the two ToCss traits. Then inspect the style_derive macro and cssparser-macros to determine the merge scope. Done means the duplicated trait and macro functionality are consolidated without losing the existing behavior.
Written by the indexing model from the issue text.
Description
cssparser and style_traits both have ToCss that are very similar, but have some slight differences. In order to simplify implementations, I'm happy to do the work to merge these (including the macro from style_derive into cssparser-macros), but I wanted to make sure there wasn't a reason for the split before I got started?
- Dominant language
- Rust
- Stars
- 869
- Forks
- 152
- Avg merge
- 15h 8m
- Merged PRs (30d)
- 12
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from servo/rust-cssparser
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
servo/rust-cssparser#440 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
servo/rust-cssparser#439 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
servo/rust-cssparser#434 ·
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
servo/rust-cssparser#436 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
servo/rust-cssparser#423 · 5 comments ·
All issues in servo/rust-cssparser
Similar issues
-
Browser (wasm) relay client cannot connect to relays whose URL has a trailing-dot FQDN hostname Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
n0-computer/iroh#4550 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
paritytech/zombienet-sdk#591 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
farion1231/cc-switch#7638 · 1 comment ·
-
onnx-ir re-exports ModelProto and GraphProto but not NodeProto, AttributeProto and AttributeType Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100