Reconsider match_byte macro if plain match becomes optimized enough

Open
#128 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
web-dev

Research direction

Start by locating the match_byte macro and review the linked Rust and Servo pull requests to understand the optimization claim. Benchmark plain match against the macro in the affected parser paths; done means the evidence supports replacing or retaining the macro and the issue's decision is documented.

Written by the indexing model from the issue text.

Description

@nox pointed out (https://github.com/servo/rust-cssparser/pull/112#issuecomment-286152329) that https://github.com/rust-lang/rust/pull/39456 brings the same performance to plain match expressions.

Dominant language
Rust
Stars
869
Forks
152
Avg merge
15h 8m
Merged PRs (30d)
12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from servo/rust-cssparser

All issues in servo/rust-cssparser

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.