fix(run): the summary's "N unmet" counts QA gap bullets, not unmet ACs

Open Beginner friendly
#1,689 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
80/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
cli

Research direction

Start at src/commands/run-display.ts:130, where summary.unmetCount is set from failedPhase.summary.gaps.length, and read the surrounding function to see what run-log data is in scope. Find how the per-AC statuses added in #1525 are shaped in the run log's acs[], since the new count should filter on status not_met and ignore pending. Then run npx vitest run src/commands/run-display.test.ts -t "unmet count"; done when that passes with two or more tests.

Written by the indexing model from the issue text.

Description

Problem

In the #1655 smoke (2026-11-16, notes-fixture #37), the run summary said AC_NOT_MET (3 unmet). The run log's acs[] for that issue held one not_met, one pending and one met, and QA's comment said "AC coverage: 1/3 met". The count comes from src/commands/run-display.ts:130 (summary.unmetCount = failedPhase.summary.gaps.length), so it counts QA's gap bullets, which include non-AC items such as "branch is stacked on #36". It does not count unmet ACs. Since #1525, the per-AC statuses are in the run log.

Acceptance Criteria

  • AC-1: The summary's unmet count is the number of the issue's ACs with status not_met, and a pending AC is not counted as unmet. Evidence: npx vitest run src/commands/run-display.test.ts -t "unmet count" → ≥ 2 passed, 0 failed

Non-Goals

  • The QA gaps list or its rendering in the issue comment.

Done when

(N unmet) in the run summary counts the not_met ACs.

Dominant language
TypeScript
Stars
1
Forks
1
Avg merge
13h 51m
Merged PRs (30d)
59

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sequant-io/sequant

All issues in sequant-io/sequant

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.