fix(run): the summary's "N unmet" counts QA gap bullets, not unmet ACs
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 80/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- cli
Research direction
Start at src/commands/run-display.ts:130, where summary.unmetCount is set from failedPhase.summary.gaps.length, and read the surrounding function to see what run-log data is in scope. Find how the per-AC statuses added in #1525 are shaped in the run log's acs[], since the new count should filter on status not_met and ignore pending. Then run npx vitest run src/commands/run-display.test.ts -t "unmet count"; done when that passes with two or more tests.
Written by the indexing model from the issue text.
Description
Problem
In the #1655 smoke (2026-11-16, notes-fixture #37), the run summary said AC_NOT_MET (3 unmet). The run log's acs[] for that issue held one not_met, one pending and one met, and QA's comment said "AC coverage: 1/3 met". The count comes from src/commands/run-display.ts:130 (summary.unmetCount = failedPhase.summary.gaps.length), so it counts QA's gap bullets, which include non-AC items such as "branch is stacked on #36". It does not count unmet ACs. Since #1525, the per-AC statuses are in the run log.
Acceptance Criteria
- AC-1: The summary's unmet count is the number of the issue's ACs with status
not_met, and apendingAC is not counted as unmet. Evidence:npx vitest run src/commands/run-display.test.ts -t "unmet count"→≥ 2 passed, 0 failed
Non-Goals
- The QA gaps list or its rendering in the issue comment.
Done when
(N unmet) in the run summary counts the not_met ACs.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 13h 51m
- Merged PRs (30d)
- 59
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sequant-io/sequant
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
sequant-io/sequant#1682 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
sequant-io/sequant#1665 ·
Maintainers usually reply within 1 day
-
fix(assess): minimal-flags rule still assumes a ui label adds the test phase (stale after #1649)Open
Difficulty 1/5 1-3 hours Newbie friendliness 87/100
sequant-io/sequant#1662 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
sequant-io/sequant#1601 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sequant-io/sequant#1582 ·
Maintainers usually reply within 1 day
All issues in sequant-io/sequant
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
openclaw/openclaw#199885 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
feature needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
BoardGamesEmpire/board-games-empire-backend#1306 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
area:cli area:security bug priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day