feat: Hook change: Fixed hooks that run in PowerShell not blocking when the hook's program exits wi... (from Claude Code v2.1.309)

Open
#1,613 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
powershell, shell, typescript
Domain
tooling

Research direction

Read templates/hooks/pre-tool.sh, plugin/hooks/hooks.json, and templates/settings.json to trace how PowerShell hooks are configured and handled. Reproduce the two Windows failures described in the issue, then define acceptance criteria for the fixes; done means exit code 2 blocks as expected and the named hooks do not fail open when Git for Windows is absent.

Written by the indexing model from the issue text.

Description

enhancement needs-triage upstream

Upstream: Claude Code v2.1.309
Category: Hook Change
Assessment: #1612

Context

Fixed hooks that run in PowerShell not blocking when the hook's program exits with code 2, and on Windows PreToolUse and PermissionRequest hooks with "shell": "powershell" failing open when Git for Windows isn't installed

Affected Files
  • templates/hooks/pre-tool.sh
  • plugin/hooks/hooks.json
  • templates/settings.json
Opportunity

[To be analyzed during /spec phase]

Proposed Implementation

[To be determined during /spec phase]

Acceptance Criteria
  • AC-1: [To be defined]

Auto-created by /upstream assessment #1612

Dominant language
TypeScript
Stars
1
Forks
1
Avg merge
11h 3m
Merged PRs (30d)
84

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sequant-io/sequant

All issues in sequant-io/sequant

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.