Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Share the TDD test knob helper and quiet the stratum profile in parity tests

Open
  • Is something wrong?
#2,244 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
54/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
c
Domain
testing

Research direction

Start with tests/test_recursive_model_parity.c and tests/test_tdd_partition_metadata.c, then inspect tests/test_mat_cache_lifetime.c for the right-filter signature coverage. Factor the duplicated environment save, set, restore, and Windows shims into one shared test helper that clears the listed worker-width knobs. Done when both tests build under MSVC, the parity test log is under 5 KB, and the guard comment accurately describes its coverage.

Written by the indexing model from the issue text.

Description

Summary

Test hygiene items left after #2127 (PR #2237).

  1. Shared knob helper. tests/test_recursive_model_parity.c and tests/test_tdd_partition_metadata.c each save, set and restore TDD environment knobs and carry their own _WIN32 setenv/unsetenv shim. Factor this into one test helper header. The helper should also clear the knobs that silently change worker width, so that a developer's environment cannot turn a positive control red or make a parity check vacuous:
    • WIRELOG_TDD_MAX_ACTIVE_WORKERS;
    • WIRELOG_TDD_GLOBAL_READ_MAX_ACTIVE_WORKERS;
    • WIRELOG_TDD_REPLICATE_W1.
  2. Log noise. Both tests set WIRELOG_TDD_STRATUM_PROFILE=1 to read the selected strategy. In the parity test that prints about 45 KB into the test log per run. Read the strategy through an API or a test hook instead, or capture and drop the profile output.
  3. Right-filter guard wording. test_right_filter_guard in tests/test_recursive_model_parity.c passes with or without the #2127 cache-key fix: a right-filtered input has its own relation identity, or bypasses the cache. The right-filter part of the join signature is checked only by tests/test_mat_cache_lifetime.c. Reword the comment so it does not read as end-to-end coverage of that part of the signature.

Acceptance

  • Both tests use the shared helper and build under MSVC.
  • The parity test log is under 5 KB.
Dominant language
C
Stars
18
Forks
2
Avg merge
8h 15m
Merged PRs (30d)
216

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from semantic-reasoning/wirelog

All issues in semantic-reasoning/wirelog

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.