[nanigans] Pull Request #13: Fix params from improper encoding
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- api
Research direction
Start by reviewing the migrated Pull Request #13 and the Nanigans integration code that constructs its parameters. Compare the old and desired encoding examples, then confirm the integration produces unescaped square brackets in the sku parameter without changing other encoding behavior.
Written by the indexing model from the issue text.
Description
Migrated from #13 by @Peripheral1994
CC @ladanazita @hankim813
This rectifies the issue where Nanigans was receiving parameters incorrectly due to QS calling encodeURIComponent on them. We now use our own function to encode.
This relies on a report from Ladan, as I've been unable to find supporting documentation myself, so having her review would be appreciated. :)
Old behavior example: &sku%5B0%5D
New and desired behavior: &sku[0]
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 134
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from segmentio/analytics.js-integrations
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
segmentio/analytics.js-integrations#784 · 2 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
segmentio/analytics.js-integrations#761 · 8 comments ·
All issues in segmentio/analytics.js-integrations
Similar issues
-
[Bug]: [MCP/CLI] Bare loopback IP addresses (127.0.0.1:port) and hosts with ports fail to navigate due to erroneous scheme inferencePossibly taken @alok-108 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
microsoft/playwright#43263 ·
Maintainers usually reply within 1 day
-
bug traffic
Difficulty 2/5 Under an hour Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
processing/p5.sound.js#123 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
PhilflowIO/dav-mcp#146 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
career-ops-hq/career-ops#4910 · 2 comments ·
Maintainers usually reply within 2 days