RebuildGeom rebuilds vertex buffers needlessly

Open Beginner friendly
  • Is something wrong?
#6,653 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@trish-sl is already working on this.

Since Nov 7, 2026.

  • #6654 by @trish-sl — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
cpp
Domain
game-dev, performance

Research direction

Find LLSpatialPartition::rebuildGeom and inspect the vertex-buffer size comparison shown in the issue. Check nearby code or tests to confirm which buffer count should be compared with index_count; done when the comparison checks the appropriate counts and the buffer is not needlessly rebuilt.

Written by the indexing model from the issue text.

Description

triage
Description

LLSpatialPartition::rebuildGeom 's comparison is inadequate (likely an unintended bad copy paste) and causes the vertex buffer to be thrown away and rebuilt on every rebuild.

The issue is comparing vertex with indices here:

group->mVertexBuffer->getNumVerts() != vertex_count ||
                group->mVertexBuffer->getNumVerts() != index_count
Dominant language
C++
Stars
310
Forks
155
Avg merge
1d 2h
Merged PRs (30d)
111

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from secondlife/viewer

All issues in secondlife/viewer

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.