feat: a TypeScript or JavaScript class field with a quoted name declares no field
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, typescript
- Domain
- devtools
Research direction
Start in internal/indexer/tsextract, where class field extraction for TypeScript, TSX and JavaScript lives, and find the branch that skips string-literal field names. Read the comment at line 14 of datadecl_test.go and the assertion that no Box."quoted" node exists, then check docs/LANGUAGE-CAPABILITY-MATRIX.md lines 153, 160 and 167. Done when class Box { "quoted" = 4; } yields a Box."quoted" field node with the contains edge, the test assertion is updated, and go test ./internal/indexer/tsextract/... passes.
Written by the indexing model from the issue text.
Description
What exists today?
Class field extraction for TypeScript, TSX and JavaScript in internal/indexer/tsextract, as documented at docs/LANGUAGE-CAPABILITY-MATRIX.md lines 153, 160 and 167.
How does it behave now?
class Box { "quoted" = 4; } has a static name, but the extractor emits no field for it. internal/indexer/tsextract/datadecl_test.go asserts that no Box."quoted" node exists. The comment at line 14 of that file states that a quoted field name declares no field.
How should it behave?
Emit a field named by the string literal's value, with the same contains edge and references as an identifier-named field. The graph then holds a Box."quoted" field node for class Box { "quoted" = 4; }. Computed names such as [key] = 3 stay out of scope.
What kind of improvement?
Correctness in an edge case.
Would this change existing behavior?
Yes, but only for classes with quoted field names. Box gains a field node, references to Box."quoted" resolve to it, and the assertion in datadecl_test.go changes with the fix.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked that the current behavior is not a deliberate decision in
openspec/specs/
- Dominant language
- Go
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 16m
- Merged PRs (30d)
- 107
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from seanb4t/codegraph-go
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
seanb4t/codegraph-go#380 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#379 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
seanb4t/codegraph-go#362 ·
Maintainers usually reply within 1 day
-
area:query bug priority:low spec-needed
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
seanb4t/codegraph-go#355 ·
Maintainers usually reply within 1 day
All issues in seanb4t/codegraph-go
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day