chore(test): JavaScript and TSX have no semantic lifecycle or query cases

Open
#267 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
62/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Domain
testing-qa

Research direction

Start with testdata/semantic/README.md, which sets the rule that acceptance cases are written from the source and target spec before reading CodeGraph output. Compare the existing development/ and heldout/ cases for Go, Java, Python and TypeScript with the four JavaScript and TSX cases listed in the issue. Add a lifecycle case and a public-queries case under development/, plus an acceptance-queries case under heldout/, for each of JavaScript and TSX. Done when the semantic gate runs and those new cases are picked up for both languages.

Written by the indexing model from the issue text.

Description

area:ci chore priority:low
What kind of chore?

Test infrastructure

What needs doing?

Add lifecycle and public query cases for JavaScript and TSX to testdata/semantic/.

Go, Java, Python and TypeScript each have a lifecycle case and a public-queries case under development/, and an acceptance-queries case under heldout/. JavaScript and TSX have two cases each, and those cases cover only the declarations and resolution dimensions:

  • development/javascript/callable-declarations
  • heldout/javascript/module-functions
  • development/tsx/components
  • heldout/tsx/nested-components

Write new acceptance cases from the source and the target specification before you look at CodeGraph output, as testdata/semantic/README.md requires.

Why now?

#264 listed this as a known limit. Without these cases, the semantic gate does not detect a lifecycle or query regression that affects only JavaScript or TSX. The other four languages have this coverage.

Does this touch anything load-bearing?
  • The release pipeline (release.yml, .goreleaser.yaml, signing)
  • The upgrade identity (internal/upgrade/verify.go)
  • The perf baseline (tools/bench/baseline.json)
  • The graph schema / meta-key layout
  • None of these
Before submitting
  • I searched existing issues and this is not a duplicate
Dominant language
Go
Stars
0
Forks
0
Avg merge
5h 16m
Merged PRs (30d)
107

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from seanb4t/codegraph-go

All issues in seanb4t/codegraph-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.