chore(test): JavaScript and TSX have no semantic lifecycle or query cases
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 62/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- go, java, javascript, python, typescript
- Domain
- testing-qa
Research direction
Start with testdata/semantic/README.md, which sets the rule that acceptance cases are written from the source and target spec before reading CodeGraph output. Compare the existing development/ and heldout/ cases for Go, Java, Python and TypeScript with the four JavaScript and TSX cases listed in the issue. Add a lifecycle case and a public-queries case under development/, plus an acceptance-queries case under heldout/, for each of JavaScript and TSX. Done when the semantic gate runs and those new cases are picked up for both languages.
Written by the indexing model from the issue text.
Description
What kind of chore?
Test infrastructure
What needs doing?
Add lifecycle and public query cases for JavaScript and TSX to testdata/semantic/.
Go, Java, Python and TypeScript each have a lifecycle case and a public-queries case under development/, and an acceptance-queries case under heldout/. JavaScript and TSX have two cases each, and those cases cover only the declarations and resolution dimensions:
development/javascript/callable-declarationsheldout/javascript/module-functionsdevelopment/tsx/componentsheldout/tsx/nested-components
Write new acceptance cases from the source and the target specification before you look at CodeGraph output, as testdata/semantic/README.md requires.
Why now?
#264 listed this as a known limit. Without these cases, the semantic gate does not detect a lifecycle or query regression that affects only JavaScript or TSX. The other four languages have this coverage.
Does this touch anything load-bearing?
- The release pipeline (
release.yml,.goreleaser.yaml, signing) - The upgrade identity (
internal/upgrade/verify.go) - The perf baseline (
tools/bench/baseline.json) - The graph schema / meta-key layout
- None of these
Before submitting
- I searched existing issues and this is not a duplicate
- Dominant language
- Go
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 16m
- Merged PRs (30d)
- 107
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from seanb4t/codegraph-go
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
seanb4t/codegraph-go#380 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#379 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
seanb4t/codegraph-go#362 ·
Maintainers usually reply within 1 day
-
area:query bug priority:low spec-needed
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
seanb4t/codegraph-go#355 ·
Maintainers usually reply within 1 day
All issues in seanb4t/codegraph-go
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day