chore(web): migrate the UI to SvelteKit 3 and drop the two audit exceptions

Open
#184 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Domain
frontend, security

Research direction

Start with the errors listed in the issue: run pnpm run build and svelte-check in web/, then open web/src/lib/browse-nav.ts (the goto() call near line 140) and the page.url reads in web/src/routes/+layout.svelte and web/src/routes/browse/+page.svelte. The bits-ui peer on kit 3 is an upstream blocker, so check that before editing. Done means task web:test, task web:build and task web:drift pass on kit 3, and audit.ignore and the cookie override are gone from web/pnpm-workspace.yaml.

Written by the indexing model from the issue text.

Description

area:ui chore priority:low

Problem

Two low-severity @sveltejs/kit advisories are fixed only in kit 3:

  • GHSA-pfhg-q3qv-9q6r: URL redirection to an untrusted site through an enhanced form submission.
  • GHSA-27mw-82g8-phjj: XSS through an untrusted cache-control header in a prerendered page.

Neither is reachable in this UI. web/src/routes/+layout.ts sets ssr = false and prerender = false, the UI has no use:enhance, no form actions, no setHeaders and no server files. #183 therefore lists both under audit.ignore in web/pnpm-workspace.yaml, so task web:audit passes. That exception should go when the UI moves to kit 3.

What the migration needs

A trial upgrade (kit 3.1.0, adapter-static 4.0.0, svelte 5.57.2) found:

  • pnpm run build fails with six module_removed_lib errors: kit 3 removed modules the UI imports.
  • svelte-check reports eight errors:
    • page.url and its searchParams are now read-only (ReadonlyURLSearchParams) at src/routes/+layout.svelte:21,69, src/routes/browse/+page.svelte:38,215,219,228 and src/routes/workbench/+page.svelte:50;
    • goto() no longer accepts noScroll (src/lib/browse-nav.ts:140).
  • vitest exits 1 although all 48 tests pass, so something in the test setup breaks under kit 3.
  • [email protected], pulled in by [email protected], declares an optional peer on kit ^2.21.0. runed 0.38 supports kit 3, but bits-ui has not moved to it yet.

Done when

  • The UI builds and passes task web:test, svelte-check, task web:build, task web:drift and the UI gates on kit 3.
  • audit.ignore in web/pnpm-workspace.yaml is empty or gone.
  • The cookie@<0.7.0 override in web/pnpm-workspace.yaml is dropped: kit 3 depends on cookie ^2.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KU8UVZn3cua2NAQprLqhhG

Dominant language
Go
Stars
0
Forks
0
Avg merge
5h 16m
Merged PRs (30d)
107

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from seanb4t/codegraph-go

All issues in seanb4t/codegraph-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.