fix(daemon): on Linux a forward wall-clock step may make a live daemon's own lock read as stale
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- go, linux
- Domain
- operating-systems
Research direction
Start in internal/daemon/procstart_linux.go, where processStartTime combines btime from /proc/stat with the start tick from /proc/<pid>/stat, and check the lock and registry staleness comparison that uses procStartTimeSlack. First confirm the wall-clock step effect by reading btime before and after a 10 s forward step on Linux. Done means either a corroboration check against the start tick count for same-boot records, or a documented limit next to procStartTimeSlack, with the fix confirmed in the daemon tests.
Written by the indexing model from the issue text.
Description
What happens
On Linux, processStartTime (internal/daemon/procstart_linux.go) works out a process's start time when it reads it: btime from /proc/stat plus the tick count from /proc/<pid>/stat. The kernel computes btime from the current wall-clock offset, so a step of the wall clock moves it. Two examples of such a step are an NTP step and a WSL2 resume.
After a forward step of more than procStartTimeSlack (5 s), a live daemon's own lock and registry record would read as stale. Another acquire would then remove the lock (INDX-05), and List would prune the record.
This is unconfirmed: it comes from reading the code, not from a reproduction. The problem predates #146. The #146 change narrows it, because after a backward step the record now corroborates.
To confirm
- On Linux, read
btimefrom/proc/stat. - Step the wall clock forward 10 s.
- Read
btimeagain and compare.
What should happen
If this is confirmed, corroborate a record from the same boot against a value that a clock step does not move, for example the start tick count. Otherwise, document the limit next to procStartTimeSlack.
Refs #146.
🤖 Generated with Claude Code
- Dominant language
- Go
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 16m
- Merged PRs (30d)
- 107
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from seanb4t/codegraph-go
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
seanb4t/codegraph-go#380 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#379 ·
Maintainers usually reply within 1 day
-
chore needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
seanb4t/codegraph-go#362 ·
Maintainers usually reply within 1 day
-
area:query bug priority:low spec-needed
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
seanb4t/codegraph-go#355 ·
Maintainers usually reply within 1 day
All issues in seanb4t/codegraph-go
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day