Support drivers other than PostgreSQL
@albireox is already working on this.
Since Sep 22, 2019.
Assessment
This issue has not been assessed yet.
Description
Right now it's hardcoded in sdssdb that all the databases are PostgreSQL. In principle we may need to support other databases (e.g. SQLite or SQL Server) and should be able to use all the current framework. Both Peewee and SQLA support multiple drivers.
On the SQLA side this seems relatively simple, since the driver is specified as a string. For Peewee is a bit more complicated; we'd need to create a PeeweeBaseDatabaseConnection and then subclass from the appropriate Peewee connection class and make sure the __init__ is run correctly.
- Dominant language
- Python
- Stars
- 8
- Forks
- 2
- Avg merge
- 10d 31m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sdss/sdssdb
-
psycopg3 issuesOpen
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Reloading the database doesn't trigger reflectionMay be free again @albireox claimed this 145 days ago, and no pull request is open. Open
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
question
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Similar issues
-
difficulty:2 enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
MakazhanAlpamys/Soup#2309 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
google-deepmind/tapnet#173 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Netcracker/qubership-ai-packages#203 ·
Maintainers usually reply within 1 day
-
PAC Wording
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day