Fix typo in argument names in `align_elements_using_landmarks()`

Open Beginner friendly
#229 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
data

Research direction

Start at the definition of align_elements_using_landmarks() and search the repository notebooks and call sites for the plural argument name, since notebooks are not covered by CI. Correct the argument naming consistently and verify that the affected notebook usage still works; the issue does not name a specific test file.

Written by the indexing model from the issue text.

Description

needs: triage priority: low 
def align_elements_using_landmarks(
    references_coords: Union[GeoDataFrame | DaskDataFrame],

should be reference_coords.

Not gonna fix now otherwise it will silently break the notebooks, as they are not in the CI yet.

Dominant language
Python
Stars
394
Forks
95
Avg merge
3d 9h
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from scverse/spatialdata

All issues in scverse/spatialdata

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.