WebSockets rewrite
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, nodejs, wordpress
Research direction
Review the changes described for wsConnectUserToServer in api2.js, the wpIdentity WebSocket package switch, and the Caddy configuration shown in the issue. Check the server log and client behavior against the retry limits and WebSocket routing; done means failed connections no longer retry indefinitely or fall back to HTTP unexpectedly.
Written by the indexing model from the issue text.
Description
There have been problems over time with the WebSocket functionality in WordLand and wpIdentity. But I think I've gotten it stabilized, and since @scotthansonde was involved in this, a long time ago, I thought I should close the loop.
- I rewrote wsConnectUserToServer in api2.js to wait 10 seconds between retries after a failed connection, and to only try 100 times, and after that it gives up. You can reload the page to get another set of tries. Previously it waited 1 second and retried indefinitely.
- I switched the websockets package wpIdentity was using from nodejs-websocket to ws. This was based on advice I got from ChatGPT and Claude.ai, saying that nodejs-websocket was not being maintained, and the gold standard for everyone was ws.
- I changed the Caddy config file on the server, per the advice of ChatGPT, to make sure that failed WS connections didn't fall back to HTTP connections, which is what I was seeing in the logfile, along with the steady stream of errors in the user's JS console (this came up the other day in a bug report on the wordlandSupport repo issues list.
The result? It's much calmer in the server log. This is kind of mysterious, I didn't expect it to settle down so quickly because there must have been some old clients out there reconnecting every second?
The new Caddy file
{
on_demand_tls {
ask http://localhost:1339/isdomainvalid
}
}
https:// {
tls {
on_demand
}
@websocketsWordlandSocial {
host wordland.social
header Connection *Upgrade*
header Upgrade websocket
}
@httpWordlandSocial {
host wordland.social
}
reverse_proxy @websocketsWordlandSocial localhost:1502
reverse_proxy @httpWordlandSocial localhost:1339
# Optional: fallback for other domains
reverse_proxy localhost:1339
}
Screen shot of server log with a client trying to connect every second
- Dominant language
- JavaScript
- Stars
- 21
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from scripting/wpIdentity
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
scripting/wpIdentity#6 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
scripting/wpIdentity#5 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
scripting/wpIdentity#2 · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
scripting/wpIdentity#1 ·
All issues in scripting/wpIdentity
Similar issues
-
bug customer-eng Durable Agents Inngest status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
githubnext/gh-aw-cao#13475 ·
-
[BUG]: "Clear All" in Settings doesn't clear the saved analysis, old data comes back after reload Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
AOSSIE-Org/OrgExplorer#253 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
oxc-project/oxc#26944 ·
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100