core: correct the embedding contract cancellation-window explanation
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- documentation, testing
Research direction
Start with the explanatory comment above the constants at lines 51-59 of packages/core/src/testing/embeddings.ts, then read runEmbeddingProviderContract (lines 70-142) to see how the live-signal and early/late abort checks use separate query invocations. Correct the comment's ordering claim so it separates the 1000ms live-signal observation from the 50/700ms pending-query bounds and the 400ms post-abort allowances, and check nearby docs for the same claim. Done means the comment matches the code, the executable diff is empty, and any source citations are updated in the same change.
Written by the indexing model from the issue text.
Description
Out of scope
Changing published contract timing, provider behavior, schemas, runtime assertions or fixture scheduling; changing the private-clock implementation in #1942.
Context
Source review during #1855/#1942 found an inaccurate explanation in the published embedding contract helper at inspected main 58f572c4d2f86fe55d76ff053fb315b83e549158.
UNCANCELLED_MS is 1000 (packages/core/src/testing/embeddings.ts:51), ABORT_AFTER_MS is [50, 700] (packages/core/src/testing/embeddings.ts:53), and REJECT_WITHIN_MS is 400 (packages/core/src/testing/embeddings.ts:59). The comment at lines54–58 says the late abort window opens after UNCANCELLED_MS; for a still-pending query its nominal start is700, before1000. The nominal post-abort windows end at450 and1100. A query that settles before its initial observation bound can return from settleWithin earlier; the constants are not a claim that every malformed query reaches those nominal abort times. The live-signal observation and the early/late abort checks use separate query invocations (runEmbeddingProviderContract, packages/core/src/testing/embeddings.ts:70-142).
This is a source-comment accuracy issue, not evidence that the current contract oracle is broken. It is supporting documentation work outside the test-cost epic's delivery scope.
Scope
Correct the explanation to match the current independent live-signal and cancellation observations. Check nearby documentation for the same incorrect ordering claim.
Acceptance criteria
- The comment accurately distinguishes the1000ms live-signal observation from the50/700ms nominal pending-query observation bounds and400ms post-abort allowances.
- It does not claim700 is later than1000 or imply all observations share one query timeline.
- All constants, executable statements, exported types, native caller tests and expected malformed-provider outcomes remain unchanged.
- Any affected source citations are reconciled in the same change.
Verification
Review the comment against the actual constants and control flow. Verify the executable diff is empty and run the required focused preflight/citation checks. This comment correction needs no new test or expensive behavior rerun solely to prove wording.
Contract impact
None. The published timing and runtime behavior remain unchanged.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 5h 38m
- Merged PRs (30d)
- 960
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from schlessera/brain-kit
-
area: ci type: test
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
schlessera/brain-kit#2769 ·
Maintainers usually reply within 1 day
-
agent-ready area: ui-server priority: p2 type: test
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
schlessera/brain-kit#2758 ·
Maintainers usually reply within 1 day
-
agent-ready area: ui-react blocked priority: p0 type: fix
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
schlessera/brain-kit#2723 · 1 comment ·
Maintainers usually reply within 1 day
-
agent-ready area: ci area: ui-react priority: p2 type: test
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
schlessera/brain-kit#2615 · 1 comment ·
Maintainers usually reply within 1 day
-
agent-ready area: ci area: docs type: docs
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
schlessera/brain-kit#2612 ·
Maintainers usually reply within 1 day
All issues in schlessera/brain-kit
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
openclaw/openclaw#182077 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
aikido high security
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
dequelabs/axe-linter-action#161 ·
-
[Feature Request] Update the DimCode agent icon to the 45:32 brand markPossibly taken @eric8810 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
lyswhut/lx-music-desktop#3026 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
abhigyanpatwari/GitNexus#3704 ·
Maintainers usually reply within 1 day