BREAKING: Rework run() arguments
@jmgate is already working on this.
Since May 9, 2024.
Assessment
This issue has not been assessed yet.
Description
Tasks
- Revert 520b68e18c7e492ecec529d4d0a64e2f04b180af.
- Switch the first argument to the
run()method from a string to a list of strings to protect against command injection in the shell. - Make any associated changes to bring everything in sync.
Note: This will be a breaking change, but it will be worthwhile to remove the possibility of this unsafe behavior.
- Dominant language
- Python
- Stars
- 23
- Forks
- 2
- Avg merge
- 5d 4h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sandialabs/staged-script
-
Quick Type: Refactor
Difficulty 3/5 1-2 days Newbie friendliness 35/100
sandialabs/staged-script#300 · 1 comment ·
-
Type: Feature
Difficulty 4/5 3-5 days Newbie friendliness 35/100
sandialabs/staged-script#172 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
sandialabs/staged-script#139 ·
-
Add Trilinos build scriptMay be free again @jmgate claimed this 769 days ago, and no pull request is open. OpenType: Documentation
sandialabs/staged-script#98 · 1 comment · 1 assignee ·
-
Save script execution summaryMay be free again @jmgate claimed this 769 days ago, and no pull request is open. OpenType: Feature
sandialabs/staged-script#97 · 1 assignee ·
All issues in sandialabs/staged-script
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 66/100
AlexsLemonade/scpca-docs#518 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 95/100
rocketride-org/rocketride-server#2705 · 1 comment ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Metabuilder-Labs/tokenjam#786 ·
Maintainers usually reply within 1 day
-
prototype(verifier_token): map disallowed warning to contraindicated before composite precedence checkPossibly taken @drk-ram claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
agentrust-io/trace-spec#582 ·
Maintainers usually reply within 1 day
-
area:cli priority:low refactor size:small
Difficulty 1/5 Under an hour Newbie friendliness 88/100
RonaldHensbergen/composable-data-stack#906 ·
Maintainers usually reply within 1 day