BREAKING: Refactor retry argument attributes
Assessment
This issue has not been assessed yet.
Description
Mypy doesn't like that the retry argument attributes are defined dynamically when a class is instantiated, so it'll complain that they don't exist when a subclass developer is trying to modify them when overriding/extending the parser. If instead of having separate attributes per registered stage, we just had a dict where the keys are the stage names, mypy would be happy.
Note: This will be a breaking change.
- Dominant language
- Python
- Stars
- 23
- Forks
- 2
- Avg merge
- 5d 4h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sandialabs/staged-script
-
Quick Type: Refactor
Difficulty 3/5 1-2 days Newbie friendliness 35/100
sandialabs/staged-script#300 · 1 comment ·
-
Type: Feature
Difficulty 4/5 3-5 days Newbie friendliness 35/100
sandialabs/staged-script#172 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
sandialabs/staged-script#139 ·
-
Add Trilinos build scriptMay be free again @jmgate claimed this 768 days ago, and no pull request is open. OpenType: Documentation
sandialabs/staged-script#98 · 1 comment · 1 assignee ·
-
Save script execution summaryMay be free again @jmgate claimed this 768 days ago, and no pull request is open. OpenType: Feature
sandialabs/staged-script#97 · 1 assignee ·
All issues in sandialabs/staged-script
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Status: Triaged Type: Enhancement
Difficulty 1/5 Under an hour Newbie friendliness 82/100
canonical/craft-store#448 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
good first issue research size:s skill:numerics sub-issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
SKaiNET-developers/SKaiNET#1372 ·
Maintainers usually reply within 1 day
-
debt
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoft/vscode-flake8#601 ·
Maintainers usually reply within 1 day