Learning hours roster aggregate is slow (161 ms, 74% of LearningHoursController#index)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 62/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- database, performance
Research direction
Start with app/models/learning_hour.rb and inspect the two roster aggregate methods, then review app/services/learning_hours_dashboard_rows_service.rb and the existing indexes before checking the query plan. The issue suggests a composite index, grouping change, or caching; preserve the casa_org_id scope and use the listed request and system specs to check behavior. Done means the aggregate is faster and cross organization scoping still works.
Written by the indexing model from the issue text.
Description
Problem
Scout APM, Slow Query Insights (7 days to 2026-11-15): the LearningHour roster aggregate behind LearningHoursController#index is 161 ms per query, 74% of that endpoint's response time. It is new this week.
Root cause
LearningHour.all_volunteers_learning_hours (admins) and supervisor_volunteers_learning_hours (supervisors) in app/models/learning_hour.rb join users, filter on users.casa_org_id and learning_hours.occurred_at, then GROUP BY users.display_name, users.id and SUM(...). learning_hours only has an index on user_id, so the occurred_at range filter scans every learning hour for the matching users. Cost grows with the number of entries ever logged.
The controller then does rows.to_a, searches and paginates in Ruby (app/controllers/learning_hours_controller.rb). That is fine at roster size, but the aggregate still runs in full on every page view, including every pagination click.
Suggested fix (pick one or combine)
- Run
EXPLAIN (ANALYZE, BUFFERS)on the query in a production console or a copy of the data and confirm a seq scan onlearning_hours. - Add a composite index
add_index :learning_hours, [:user_id, :occurred_at], algorithm: :concurrently(Strong Migrations requiresdisable_ddl_transaction!). Check the plan again afterwards. - Group by
users.idonly and selectMAX(users.display_name)(or useusers.idin the GROUP BY withusers.display_namefunctionally dependent, which Postgres allows whenidis the primary key). This avoids sorting and grouping on a text column. - Optional: cache the per-volunteer totals for the selected period for a few minutes (
Rails.cache.fetch, keyed by org, role and period), so pagination clicks do not re-run the aggregate. - Keep the cross-org check: the query must still be scoped to
casa_org_id. Runspec/requests/learning_hours_spec.rbandspec/system/learning_hours/.
Related: #6505 (ensure indexes present).
Difficulty: intermediate. Files: app/models/learning_hour.rb, app/services/learning_hours_dashboard_rows_service.rb, a new migration under db/migrate/.
- Dominant language
- Ruby
- Stars
- 384
- Forks
- 558
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 63
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rubyforgood/casa
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
rubyforgood/casa#7404 ·
Maintainers usually reply within 1 day
-
Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
rubyforgood/casa#7402 ·
Maintainers usually reply within 1 day
-
Remove the bin/bundle binstub (Heroku warns it can break Bundler on deploy)Possibly taken @Akash-Dhanwate claimed this 8 days ago. Opendependencies Difficulty: Easy Good First Issue
Difficulty 1/5 Under an hour Newbie friendliness 82/100
rubyforgood/casa#7325 · 2 comments ·
Maintainers usually reply within 1 day
-
Reports page: move export-button disable/re-enable into a Stimulus controllerMay be free again @Akash-Dhanwate claimed this 9 days ago, and no pull request is open. OpenDifficulty: Easy Good First Issue Help Wanted javascript
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rubyforgood/casa#7311 · 2 comments ·
Maintainers usually reply within 1 day
-
New case: use Stimulus for the "I don't know the court date yet" toggleMay be free again @Aryankn29 claimed this 9 days ago, and no pull request is open. OpenDifficulty: Easy Good First Issue Help Wanted javascript
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rubyforgood/casa#7310 · 1 comment ·
Maintainers usually reply within 1 day
All issues in rubyforgood/casa
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
internetee/registry#2984 ·
Maintainers usually reply within 6 days
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPossibly taken @mimosa claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
riscv/riscv-unified-db#2829 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
docker-library/ruby#534 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100