Delete dead read_more.js (replaced by truncated_text controller)
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start by running the grep from the checklist to confirm nothing in app/ still uses js-read-more, js-read-less or js-full-text outside app/javascript/src/read_more.js and its test. The files involved are app/javascript/src/read_more.js, app/javascript/__tests__/read_more.test.js, and the require('./src/read_more') line in app/javascript/application.js. Done means those files are deleted and the require is removed, with npm run test and bin/lint passing.
Written by the indexing model from the issue text.
Description
What
app/javascript/src/read_more.js toggles .js-read-more / .js-read-less links. No view renders those classes any more: the redesign replaced them with the truncated_text Stimulus controller (app/javascript/controllers/truncated_text_controller.js).
Checklist
- Confirm
grep -rn "js-read-more\|js-read-less\|js-full-text" app/only matchesread_more.jsand its test - Delete
app/javascript/src/read_more.jsandapp/javascript/__tests__/read_more.test.js - Remove
require('./src/read_more')fromapp/javascript/application.js -
npm run testpasses
Before you start
- Comment here to be assigned. Setup is
bin/setup, thenbin/dev. Logins are in the README. - JS tests:
npm run test. Lint:bin/lint. - Part of #7301 (removing jQuery). Keep this PR to just this file.
- Dominant language
- Ruby
- Stars
- 384
- Forks
- 558
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 63
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rubyforgood/casa
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
rubyforgood/casa#7404 ·
Maintainers usually reply within 1 day
-
Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
rubyforgood/casa#7402 ·
Maintainers usually reply within 1 day
-
Remove the bin/bundle binstub (Heroku warns it can break Bundler on deploy)Possibly taken @Akash-Dhanwate claimed this 8 days ago. Opendependencies Difficulty: Easy Good First Issue
Difficulty 1/5 Under an hour Newbie friendliness 82/100
rubyforgood/casa#7325 · 2 comments ·
Maintainers usually reply within 1 day
-
Reports page: move export-button disable/re-enable into a Stimulus controllerMay be free again @Akash-Dhanwate claimed this 9 days ago, and no pull request is open. OpenDifficulty: Easy Good First Issue Help Wanted javascript
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rubyforgood/casa#7311 · 2 comments ·
Maintainers usually reply within 1 day
-
New case: use Stimulus for the "I don't know the court date yet" toggleMay be free again @Aryankn29 claimed this 9 days ago, and no pull request is open. OpenDifficulty: Easy Good First Issue Help Wanted javascript
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rubyforgood/casa#7310 · 1 comment ·
Maintainers usually reply within 1 day
All issues in rubyforgood/casa
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
internetee/registry#2984 ·
Maintainers usually reply within 6 days
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPossibly taken @mimosa claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
riscv/riscv-unified-db#2829 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
docker-library/ruby#534 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100