Replace uses of "dropdown" with respective ViewComponent

Open
#5,845 7 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@iamronakgupta is already working on this.

Since Jun 19, 2024.

  • #5907 by @iamronakgupta — closed without merging

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
rails, ruby
Domain
frontend

Research direction

Start with app/components/dropdown_menu_component.rb, then review the linked repository search results for dropdown implementations in *.html.erb files. Compare each result with the existing ViewComponent and replace the applicable uses. Done means the identified dropdowns use the respective component without changing their intended behavior.

Written by the indexing model from the issue text.

Description

🖥️ Frontend Difficulty: Intermediate Help Wanted

What type(s) of user does this feature affect?

Steve Ballmer DEVELOPERS DEVELOPERS DEVELOPERS

Description

This application uses ViewComponent. While we have made multiple components we haven't replaced old code in all the place where those view components could be used.

Find the places that implement dropdowns but don't use the dropdown component (https://github.com/rubyforgood/casa/blob/main/app/components/dropdown_menu_component.rb). Replace them.

This should be a good place to start with replacements: https://github.com/search?q=repo%3Arubyforgood%2Fcasa+AND+path%3A*.html.erb+AND+%2Fdropdown%5B%22%7C+%5D%2F&type=code

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

Dominant language
Ruby
Stars
384
Forks
558
Avg merge
1d 7h
Merged PRs (30d)
63

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rubyforgood/casa

All issues in rubyforgood/casa

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.