XPath function name typo silently ignored

Open
#351 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
ruby
Domain
backend

Research direction

Start at REXML::XPath.match, using the misspelled-function examples in the issue to trace how XPath function names are handled. Verify that an unknown function no longer passes silently, and check both the positoin() case and the namae() case for consistent behavior.

Written by the indexing model from the issue text.

Description

If a function name is misspelled, REXML::XPath.match doesn't warn or raise.

REXML::XPath.match doc, '//foo[positoin()=1]'

Weird case:

doc = REXML::Document.new('<foo><namae>bar</namae><bar/></foo>')
REXML::XPath.match doc, '//*[namae()="bar"]'
#=> [<foo> ... </>]
Dominant language
Ruby
Stars
181
Forks
105
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby/rexml

All issues in ruby/rexml

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.