Improve `rbs_hash_t`

Open
#2,583 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
c, ruby
Domain
tooling

Research direction

Read Ruby's st.c and include/ruby/st.h to understand the hash-table implementation proposed in the issue, then locate the current rbs_hash_t implementation in RBS. Preserve the existing get/set behavior while replacing the linked-list linear searches with a hash table, and verify the relevant existing tests.

Written by the indexing model from the issue text.

Description

Contrary to the name, rbs_hash_t isn't actually a Hash table. It's actually a linked list that does linear searches on every get/set. This was a quick/dirty implementation to get started, but it can be improved.

Perhaps we should use st.c/st.h from Ruby?

Dominant language
Ruby
Stars
2.2k
Forks
263
Avg merge
1d 20h
Merged PRs (30d)
64

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby/rbs

All issues in ruby/rbs

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.