inline type narrowing

Open
#1,873 1 comment 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
tooling

Research direction

Start by reproducing the provided TCPSocket | SSLSocket example and trace how an is_a? check combined with && narrows the receiver. The work is done when verify_hostname is accepted after the SSLSocket check and a regression test covers this case.

Written by the indexing model from the issue text.

Description

Not sure, but I think some variations with case-statement of this work, but this does not:

# considering a @io typed as TCPSocket | SSLSocket

if @io.is_a?(SSLSocket) && @io.verify_hostname(host)
# the last statement fails because `TCPSocket | SSLSocket` does not define verify_hostname, only the latter
Dominant language
Ruby
Stars
2.2k
Forks
263
Avg merge
1d 20h
Merged PRs (30d)
64

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby/rbs

All issues in ruby/rbs

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.