Audit excluded tests on JRuby and address differences

Open
#1,123 3 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
ruby
Domain
backend

Research direction

Start by running the listed JRuby-excluded tests under JRuby and compare their behavior with the C extension; inspect the conditionals and omissions in test/json/json_generator_test.rb, test/json/json_minefield_parser_test.rb, test/json/json_parser_test.rb, and test/json/resumable_parser_test.rb. Use #1122 as the example of a latent bug. Done means fixing the applicable Java extension differences and restoring the corresponding tests, while identifying exclusions that remain valid.

Written by the indexing model from the issue text.

Description

Several tests still explicitly exclude JRuby and do not run against the Java extension. We should reexamine these and fix as many differences with the C extension as possible.

$ git grep -e "RUBY_ENGINE == [\"']jruby" test 
test/json/json_generator_test.rb:    if RUBY_ENGINE == "jruby"
test/json/json_minefield_parser_test.rb:  if RUBY_ENGINE == 'jruby'
test/json/json_parser_test.rb:    unless RUBY_ENGINE == 'jruby'
test/json/json_parser_test.rb:    omit "JRuby errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/json_parser_test.rb:    omit "JRuby errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/json_parser_test.rb:    omit "JRuby string decoding errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/resumable_parser_test.rb:    omit "JRuby not supported" if RUBY_ENGINE == "jruby"

Some of these may be valid but most involve changes made to the C extension that were never ported to the Java extension. That last one excludes all of the ResumableParser tests because that entire feature is missing from the Java extension.

See #1122 for one example of a latent bug hidden by these masks.

Dominant language
Ruby
Stars
785
Forks
390
Avg merge
7h 14m
Merged PRs (30d)
15

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby/json

All issues in ruby/json

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.