Audit excluded tests on JRuby and address differences
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by running the listed JRuby-excluded tests under JRuby and compare their behavior with the C extension; inspect the conditionals and omissions in test/json/json_generator_test.rb, test/json/json_minefield_parser_test.rb, test/json/json_parser_test.rb, and test/json/resumable_parser_test.rb. Use #1122 as the example of a latent bug. Done means fixing the applicable Java extension differences and restoring the corresponding tests, while identifying exclusions that remain valid.
Written by the indexing model from the issue text.
Description
Several tests still explicitly exclude JRuby and do not run against the Java extension. We should reexamine these and fix as many differences with the C extension as possible.
$ git grep -e "RUBY_ENGINE == [\"']jruby" test
test/json/json_generator_test.rb: if RUBY_ENGINE == "jruby"
test/json/json_minefield_parser_test.rb: if RUBY_ENGINE == 'jruby'
test/json/json_parser_test.rb: unless RUBY_ENGINE == 'jruby'
test/json/json_parser_test.rb: omit "JRuby errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/json_parser_test.rb: omit "JRuby errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/json_parser_test.rb: omit "JRuby string decoding errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/resumable_parser_test.rb: omit "JRuby not supported" if RUBY_ENGINE == "jruby"
Some of these may be valid but most involve changes made to the C extension that were never ported to the Java extension. That last one excludes all of the ResumableParser tests because that entire feature is missing from the Java extension.
See #1122 for one example of a latent bug hidden by these masks.
- Dominant language
- Ruby
- Stars
- 785
- Forks
- 390
- Avg merge
- 7h 14m
- Merged PRs (30d)
- 15
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ruby/json
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
-
Output formatting differences between jRuby 10.0.0.1 and Ruby 3.4 when converting Float to JSON.Possibly taken @headius claimed this 450 days ago. Openjruby
ruby/json#817 · 3 comments · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
-
Don't cache JRuby runtime in static fieldsMay be free again @headius claimed this 727 days ago, and no pull request is open. Openjruby
ruby/json#707 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
new feature
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
bug jruby
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
Similar issues
-
🐛 bug 👩💻 équipe CE 🧑🏭 entreprises
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
betagouv/conseillers-entreprises#4808 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
yosiat/panko_serializer#250 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
cline/mcp-marketplace#3886 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100