Deadlock when ctrl+c on syntax invalid code in multi-irb

Open
#1,164 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
cli

Research direction

Reproduce the report by starting irb, entering multi-irb, and pressing Ctrl-C on syntax-invalid input. Read lib/irb/ext/multi-irb.rb around line 186 and reline.rb around line 251 to trace the stopped thread and mutex wait. Done means Ctrl-C no longer ends with a fatal deadlock.

Written by the indexing model from the issue text.

Description

$ irb
irb(main):001> irb
Multi-irb commands are deprecated and will be removed in IRB 2.0.0. Please use workspace commands instead.
If you have any use case for multi-irb, please leave a comment at https://github.com/ruby/irb/issues/653
irb#1(main):001* do#0->irb on main (#<Thread:0x00007037632b7f68 run>: running)
#1->irb#1 on main (#<Thread:0x0000703744b6f300 /home/user/.rbenv/versions/4.0.0/lib/ruby/gems/4.0.0/gems/irb-1.16.0/lib/irb/ext/multi-irb.rb:186 sleep>: stop)

^C
/home/user/.rbenv/versions/4.0.0/lib/ruby/gems/4.0.0/gems/reline-0.6.3/lib/reline.rb:251:in 'Thread::Mutex#synchronize': No live threads left. Deadlock? (fatal)

I understand multi-irb is deprecated. 100% of the time, I enter multi-irb by accident because I didn't realize I had irb already open. So perhaps you think that fixing this is not worth the effort. I just thought I'd report it anyways.

Dominant language
Ruby
Stars
477
Forks
165
Avg merge
1d 19h
Merged PRs (30d)
5

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby/irb

All issues in ruby/irb

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.