Compilation issue dtoa.c - missing binary operator before token

Open
#569 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
c, ruby
Domain
build-system

Research direction

Start by reproducing the failure with the Docker command in the issue, then inspect the preprocessor condition around line 214 of missing/dtoa.c, included from missing.c. Check how the condition behaves with the reported compiler and Ruby 3.0.6. Done means the gem builds and loads successfully in that environment.

Written by the indexing model from the issue text.

Description

Hi there; We're just trying to compile the latest release of this gem and hitting an issue:

missing/dtoa.c:214:20: error: missing binary operator before token "("

Replication command:

docker run --rm --user jenkins --env HOME=/home/jenkins rapid7/msf-ubuntu1204-x86-omnibus:2024_04 linux32 bash -lc 'mkdir -p "$HOME/.local/share/gem/ruby/3.0.0/cache" && source /home/jenkins/.rvm/scripts/rvm && rvm use 3.0.6 && gem install bigdecimal -v 4.1.3 --platform ruby --no-document && ruby -rbigdecimal -e '\''abort unless BigDecimal::VERSION == %q(4.1.3) && BigDecimal(%q(1.25)) + BigDecimal(%q(2.75)) == 4; puts %Q(bigdecimal #{BigDecimal::VERSION}: compiled and loaded)'\'''

Error:

Using /home/jenkins/.rvm/gems/ruby-3.0.6
Building native extensions. This could take a while...
ERROR:  Error installing bigdecimal:
	ERROR: Failed to build gem native extension.

    current directory: /home/jenkins/.rvm/gems/ruby-3.0.6/gems/bigdecimal-4.1.3/ext/bigdecimal
/home/jenkins/.rvm/rubies/ruby-3.0.6/bin/ruby -I /home/jenkins/.rvm/rubies/ruby-3.0.6/lib/ruby/3.0.0 -r ./siteconf20261103-186-cilydo.rb extconf.rb
checking for __builtin_clz()... yes
checking for __builtin_clzl()... yes
checking for __builtin_clzll()... yes
checking for float.h... yes
checking for math.h... yes
checking for stdbool.h... yes
checking for stdlib.h... yes
checking for x86intrin.h... yes
checking for _lzcnt_u32() in x86intrin.h... no
checking for _lzcnt_u64() in x86intrin.h... no
checking for intrin.h... no
checking for ruby/atomic.h... yes
checking for ruby/internal/has/builtin.h... yes
checking for ruby/internal/static_assert.h... yes
checking for rb_complex_real() in ruby.h... yes
checking for rb_complex_imag() in ruby.h... yes
checking for rb_opts_exception_p() in ruby.h... yes
checking for rb_category_warn() in ruby.h... yes
checking for RB_WARN_CATEGORY_DEPRECATED in ruby.h... yes
checking for RUBY_TYPED_EMBEDDABLE in ruby.h... no
creating Makefile

current directory: /home/jenkins/.rvm/gems/ruby-3.0.6/gems/bigdecimal-4.1.3/ext/bigdecimal
make DESTDIR\= clean

current directory: /home/jenkins/.rvm/gems/ruby-3.0.6/gems/bigdecimal-4.1.3/ext/bigdecimal
make DESTDIR\=
compiling bigdecimal.c
compiling missing.c
In file included from missing.c:28:0:
missing/dtoa.c:214:20: error: missing binary operator before token "("
cc1: warning: unrecognized command line option "-Wno-tautological-compare" [enabled by default]
cc1: warning: unrecognized command line option "-Wno-self-assign" [enabled by default]
cc1: warning: unrecognized command line option "-Wno-parentheses-equality" [enabled by default]
cc1: warning: unrecognized command line option "-Wno-constant-logical-operand" [enabled by default]
cc1: warning: unrecognized command line option "-Wno-cast-function-type" [enabled by default]
make: *** [missing.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/jenkins/.rvm/gems/ruby-3.0.6/gems/bigdecimal-4.1.3 for inspection.
Results logged to /home/jenkins/.rvm/gems/ruby-3.0.6/extensions/x86-linux/3.0.0/bigdecimal-4.1.3/gem_make.out
Dominant language
C
Stars
152
Forks
99
Avg merge
3d 3h
Merged PRs (30d)
5

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby/bigdecimal

All issues in ruby/bigdecimal

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.