`with_options` doesn't do deep merge
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start at the with_options entry point and trace how parent and nested documentation options are combined. Reproduce the example from the issue, then add a regression test showing that nested attributes retain required and type while adding example values. Done means the nested documentation is deep-merged rather than replaced.
Written by the indexing model from the issue text.
Description
with_options documentation: {required: true, type: 'integer'} do
expose :posts_count, as: :posts, documentation: {example: 7}
expose :followers_count, as: :followers, documentation: {example: 105}
expose :following_count, as: :following, documentation: {example: 52}
expose :bookmarks_count, as: :bookmarks, documentation: {example: 22}
end
the example doesn't work, since documentation from nested attributes overrides parent's one.
I think they should be deep merged
- Dominant language
- Ruby
- Stars
- 730
- Forks
- 155
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ruby-grape/grape-entity
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ruby-grape/grape-entity#386 · 7 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ruby-grape/grape-entity#382 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ruby-grape/grape-entity#380 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
ruby-grape/grape-entity#373 · 2 comments ·
-
Truncate FormatterOpen
Difficulty 1/5 1-3 hours Newbie friendliness 45/100
ruby-grape/grape-entity#372 ·
All issues in ruby-grape/grape-entity
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug priority: high
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
mitakarb/beerkeeper#1259 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
agent:triaged bug bughunt pm:bundler priority:p1
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
SocketDev/socket-patch#1125 · 1 comment ·
Maintainers usually reply within 1 day