Error message out of bounds if DT hasn't been rendered before

Open
  • Is something wrong?
#1,084 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, r
Domain
frontend

Research direction

Start by running the reproducible Shiny app in the issue with DT and toggling the error before the table has rendered. Trace how the validation error is positioned, then verify that the message stays within its parent and the visual glitch no longer occurs on the first toggle.

Written by the indexing model from the issue text.

Description

The error rendering message by shiny has height = 0 and absolute positioning. This means that if the data table hasn't been rendered before, then the error is placed out of bounds from the parent div.

This may result on visual glitches such as the example below shows. (when pressing the button twice the problem is no longer visible as the parent element has a non-zero height.

image

image

Reproducible code:

library(shiny)
library(DT)

sytle_css <- "
  background-color: rgba(159,226,191,100);
  padding: 0.3em;
  border: solid green 1px;
  "

shinyApp(
  ui = fluidPage(
    fluidRow(
      column(12, actionButton("toggle_error", "Toggle error")),
      column(12, tags$div( style = sytle_css, tags$h2("A table"), DTOutput('tbl')) )
    )
  ),
  server = function(input, output) {
    output$tbl = renderDT({
      shiny::validate(
        shiny::need(
          input$toggle_error && input$toggle_error %% 2 == 1,
          "Forced error that can be toggled by pressing the button above"
        )
      )
      iris
    }, options = list(lengthChange = FALSE))
  }
)

By filing an issue to this repo, I promise that

  • I have fully read the issue guide at https://yihui.org/issue/.
  • I have provided the necessary information about my issue.
    • If I'm asking a question, I have already asked it on Stack Overflow or RStudio Community, waited for at least 24 hours, and included a link to my question there.
    • If I'm filing a bug report, I have included a minimal, self-contained, and reproducible example, and have also included xfun::session_info('DT'). I have upgraded all my packages to their latest versions (e.g., R, RStudio, and R packages), and also tried the development version: remotes::install_github('rstudio/DT').
    • If I have posted the same issue elsewhere, I have also mentioned it in this issue.
  • I have learned the Github Markdown syntax, and formatted my issue correctly.

I understand that my issue may be closed if I don't fulfill my promises.

Dominant language
JavaScript
Stars
621
Forks
177
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rstudio/DT

All issues in rstudio/DT

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.