sbx up: take back the retired MultiEdit/LS/NotebookRead denies it wrote before #572

Closed
#574 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@cwiklik is already working on this.

Since Oct 27, 2026.

  • #635 by @cwiklik — merged

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
67/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript

Research direction

Start in packages/mocactl/src/sbx/agent-config.ts at writeAgentConfig and read how recorded item operations on permissions.deny are handled by dropAt and its guards. Add the retired deny entries to the take-back flow, removing only entries recorded as written by sbx up, and update the record to match. Done when those old entries are cleaned up while hand-added entries remain; the issue does not name a test to run.

Written by the indexing model from the issue text.

Description

Follow-up from the #572 review.

#572 dropped MultiEdit, LS and NotebookRead from CLAUDE_DENY, because current Claude Code warns at every start about a deny rule naming no known tool. Repositories configured before #572 still have those three entries in .claude/settings.json. Re-running sbx up adds the new entries but doesn't remove the old ones, so those repositories keep the three warnings until sbx rm then sbx up, or a hand edit.

sbx up records what it added in .sbx/agent-config.json (op item on permissions.deny). It could remove exactly the retired deny entries that it wrote earlier, and update the record to match. It would leave any the developer added by hand.

Where

  • packages/mocactl/src/sbx/agent-config.ts: writeAgentConfig (a retired-names list, plus a take-back of matching recorded items through dropAt with its guards)

🤖 Assisted-By: Claude Code

Dominant language
TypeScript
Stars
5
Forks
11
Avg merge
8h 32m
Merged PRs (30d)
166

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rossoctl/moca

All issues in rossoctl/moca

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.