deploy/k8s: polish follow-ups from the slice 1 reviews
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- docker, eslint, kubernetes, typescript
- Domain
- devops, documentation, infrastructure, tooling
Research direction
Start by reading the checklist and the named files: deploy/k8s/overlays/ocp/kustomization.yaml, deploy/k8s/base/control-plane.yaml, the kind-ci mock-model manifest, deploy/k8s/README.md, deploy/vm/env/supervisor.env.example, redactUrl, and render.ts. Check nearby conventions and run the relevant Kubernetes validation and lint checks. Done means all seven review follow-ups are addressed without changing the documented behavior.
Written by the indexing model from the issue text.
Description
Small polish items from the task reviews of #427 (P6 on Kubernetes slice 1).
- Smaller ghostunnel image: pin
docker.io/ghostunnel/ghostunnel:v1.11.3-distroless(re-resolving the digest) instead of the default Alpine variant (deploy/k8s/overlays/ocp/kustomization.yaml). - Inert setting:
SH_SANDBOX_NAMESPACEindeploy/k8s/base/control-plane.yamlhas no effect without the pods Role. Drop it, or comment it. - kind-ci mock-model sidecar: add
/tmp(an emptyDir),HOME=/tmpand atcpSocketprobe on 18099, to match the brain-container convention. -
redactUrldoc: note thatURL.toString()normalises the URL (for example lowercasing the host), so the redacted output can differ from the input in more than the userinfo. -
deploy/vm/env/supervisor.env.example: wrap theSH_ADMIN_HOSTcomment to the template's line width. -
deploy/k8s/README.md§9.5: each session delete answers 204, or 202 if a turn is in flight. The session loop reads only the first page (?limit=or loop onnextCursor). -
render.ts: move theeslint-disable-next-linecomment directly above theanyline.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 9
- Avg merge
- 9h 31m
- Merged PRs (30d)
- 139
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rossoctl/moca
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rossoctl/moca#421 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
Similar issues
-
area: image-engine bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
snapotter-hq/SnapOtter#3885 ·
Maintainers usually reply within 1 day
-
Mend: dependency security vulnerability
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 3 days
-
pending triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug P3 UI/UX
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
openclaw/openclaw#182077 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day