Being rescued lags the rescued character and can cut off their pending action; several pets can stack it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Read do_rescue in src/act_offe.cpp and WAIT_STATE_FULL in src/utils.h to trace how rescue lag affects pending actions. Check which delayed actions have a priority that lets the rescue interrupt them, then decide whether rescue should interrupt actions and whether repeated rescues should stack lag. Done when both behaviors are decided and the resulting rescue behavior is covered.
Written by the indexing model from the issue text.
Description
Every successful rescue puts a short lag on the character who was rescued (WAIT_STATE(victim, PULSE_VIOLENCE / 3) in do_rescue, src/act_offe.cpp). If that character has a delayed action pending at the time, WAIT_STATE_FULL completes it early with subcmd = -1 and aborts it (src/utils.h, WAIT_STATE_FULL), so being rescued can cut off what you were doing.
This is existing behaviour for any rescue (a player rescuing you, or order followers rescue <name>). The rescue keywords in #311 make one case more common: order followers rescue leader sends every charmed follower at the leader, so with two or more pets the leader can be lagged once per successful rescue in a single command.
To decide:
- Should being rescued interrupt the rescued character's pending action at all?
- Should several rescues of the same character in one round stack their lag?
Not yet checked: which delayed actions this can actually cut off (for example, whether spell casting is one of them, which depends on its delay priority versus the rescue's 50).
- Dominant language
- C++
- Stars
- 3
- Forks
- 4
- Avg merge
- 18h 36m
- Merged PRs (30d)
- 87
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from returnoftheshadow/RotS_Live
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
returnoftheshadow/RotS_Live#521 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
returnoftheshadow/RotS_Live#485 ·
Maintainers usually reply within 1 day
-
Remove dead object refresh code (check_inventory_proto and friends)Possibly taken @drelidan7 claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
returnoftheshadow/RotS_Live#414 ·
Maintainers usually reply within 1 day
-
purge <player> idle-saves the immortal instead of the playerPossibly taken @bskalpavrukshab25-sketch claimed this 12 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
returnoftheshadow/RotS_Live#411 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
returnoftheshadow/RotS_Live#410 · 2 comments ·
Maintainers usually reply within 1 day
All issues in returnoftheshadow/RotS_Live
Similar issues
-
44-x-y bug :beetle:
Difficulty 1/5 Under an hour Newbie friendliness 82/100
electron/electron#55528 · 1 comment ·
Maintainers usually reply within 1 day
-
ai_p2 bug comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ClickHouse/ClickHouse#128306 · 1 comment ·
Maintainers usually reply within 1 day
-
70 Instance - Raid - Outland
Difficulty 1/5 Under an hour Newbie friendliness 85/100
azerothcore/azerothcore-wotlk#28328 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day