Notes and pens: writing code needs an overhaul before they're added
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start with do_write in act_comm.cpp at line 387, then trace the listed restyle, object version refresh, extract, and purge paths that can replace object strings while writing is open. Review the skin checks in the editor and boot code as well. Done means the writing input remains valid across those paths and note type changes are handled safely; the issue does not identify tests to run.
Written by the indexing model from the issue text.
Description
No world has pen objects today, so nobody can write on a note. If notes
and pens are ever added, the writing code needs a review first:
do_write(act_comm.cpp:387) points the writer's input at the
note's own text field (desc->str = &paper->action_description).
Anything that changes or frees that field while someone is writing
makes the next typed line go into memory that is no longer the
note's.- Object skins refuse notes as a base (editor and boot), but a copy
whose prototype changed type keeps its own note type, and restyle
checks only the prototypes. - Check every path that replaces an object's strings while it may be
open for writing: restyle, the object version refresh, extract and
purge.
- Dominant language
- C++
- Stars
- 3
- Forks
- 4
- Avg merge
- 18h 36m
- Merged PRs (30d)
- 87
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from returnoftheshadow/RotS_Live
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
returnoftheshadow/RotS_Live#521 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
returnoftheshadow/RotS_Live#485 ·
Maintainers usually reply within 1 day
-
Remove dead object refresh code (check_inventory_proto and friends)Possibly taken @drelidan7 claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
returnoftheshadow/RotS_Live#414 ·
Maintainers usually reply within 1 day
-
purge <player> idle-saves the immortal instead of the playerPossibly taken @bskalpavrukshab25-sketch claimed this 12 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
returnoftheshadow/RotS_Live#411 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
returnoftheshadow/RotS_Live#410 · 2 comments ·
Maintainers usually reply within 1 day
All issues in returnoftheshadow/RotS_Live
Similar issues
-
44-x-y bug :beetle:
Difficulty 1/5 Under an hour Newbie friendliness 82/100
electron/electron#55528 · 1 comment ·
Maintainers usually reply within 1 day
-
ai_p2 bug comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ClickHouse/ClickHouse#128306 · 1 comment ·
Maintainers usually reply within 1 day
-
70 Instance - Raid - Outland
Difficulty 1/5 Under an hour Newbie friendliness 85/100
azerothcore/azerothcore-wotlk#28328 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day