get all from a container repeats the item-limit refusal for every item
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 78/100
Research direction
Start in src/act_obj1.cpp at can_take_obj and perform_get_from_container, comparing the floor-container and carried-container paths for get all and get all.x. Trace where the item-limit refusal is emitted and where the loop continues, while leaving weight-limit handling able to process later items. Done means both container paths stop after the first item-limit refusal and print one refusal line, with behavior covered by the project’s relevant tests if an existing test location is found.
Written by the indexing model from the issue text.
Description
Problem
At the item limit, get all <container> prints one refusal line for every item left behind instead of stopping after the first.
- Container on the floor (e.g. a corpse):
can_take_obj(src/act_obj1.cpp on release-frodo fd14ca7) sends<item>: You can't carry that many items.for each remaining item. A 30-item corpse looted one slot under the limit gives 1 item and 29 refusal lines. - Container you carry: on release-frodo
perform_get_from_containerbuilds<item>: You can't hold any more items.but never sends it, so nothing is printed at all. The keyring branch (feat/keyring) sends that line, so carried containers now behave like the floor case (one line per item).
The same pattern applies to the weight limit (You can't carry that much weight.).
To consider
Stop the get all / get all.x loop at the first item-limit refusal and print a single line (for example "You can't carry any more items."), for floor and carried containers alike. Weight refusals may still want to continue, since a lighter item later in the list can fit.
Raised during the keyring branch review; not changed there.
- Dominant language
- C++
- Stars
- 3
- Forks
- 4
- Avg merge
- 18h 36m
- Merged PRs (30d)
- 87
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from returnoftheshadow/RotS_Live
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
returnoftheshadow/RotS_Live#521 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
returnoftheshadow/RotS_Live#485 ·
Maintainers usually reply within 1 day
-
Remove dead object refresh code (check_inventory_proto and friends)Possibly taken @drelidan7 claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
returnoftheshadow/RotS_Live#414 ·
Maintainers usually reply within 1 day
-
purge <player> idle-saves the immortal instead of the playerPossibly taken @bskalpavrukshab25-sketch claimed this 12 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
returnoftheshadow/RotS_Live#411 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
returnoftheshadow/RotS_Live#410 · 2 comments ·
Maintainers usually reply within 1 day
All issues in returnoftheshadow/RotS_Live
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
godotengine/godot#125004 ·
Maintainers usually reply within 1 day
-
44-x-y bug :beetle:
Difficulty 1/5 Under an hour Newbie friendliness 82/100
electron/electron#55528 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
gabime/spdlog#3698 · 1 comment ·
Maintainers usually reply within 5 days
-
ai_p2 bug comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ClickHouse/ClickHouse#128306 · 1 comment ·
Maintainers usually reply within 1 day
-
70 Instance - Raid - Outland
Difficulty 1/5 Under an hour Newbie friendliness 85/100
azerothcore/azerothcore-wotlk#28328 ·
Maintainers usually reply within 1 day