Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

On Damage Script Issue

Open
  • Is something wrong?
#173 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start by locating the on_damage script and the handling for TRIG_ON_DAMAGE, then trace how nested END_ELSE_BEGIN blocks and item assignments are evaluated. Reproduce the multiple-item check shown in the issue and compare its behavior with the expected helm and crown checks; done means the script checks both items correctly and preserves the intended dodge behavior.

Written by the indexing model from the issue text.

Description

bug Ready For Pickup Scripting

The on_damage script isn't looking correctly for multiple items see below:

[2] SYS ASSIGN_EQ        character: ch2, object: ob1, position: 6, int true/false: int1
[3] SYS SET_INT_VALUE    integer: int3, value: 26813 (ste int to spiked metal helm vnum)
[4] IF_INT_EQUAL:        compare: ob1.vnum with int3 (if they wearing helm)
[5] BEGIN                ()
[6] ACT DO_SAY           helm check 1 (ch1)((null))
[7] MSG SEND_TO_CHAR     The mewlip is unable to avoid your attack. to: ch2 ((null))
[8] END_ELSE_BEGIN       ()
[9] SYS ASSIGN_EQ        character: ch2, object: ob2, position: 6, int true/false: int1
[10] SYS SET_INT_VALUE    integer: int2, value: 26815 (set to crown vnum)
[11] IF_INT_EQUAL:        compare: ob2.vnum with int2 (if they wearing crown)
[12] BEGIN                ()
[13] ACT DO_SAY           helm check 2 (ch1)((null))
[14] MSG SEND_TO_CHAR     The mewlip is unable to avoid your attack. to: ch2 ((null))
[15] END_ELSE_BEGIN       ()
[16] ACT DO_SAY           past 2 helm checks (ch1)((null))
[17] SYS SET_INT_VALUE    integer: int1, value: 1 ()
[18] SYS SET_INT_VALUE    integer: int2, value: 2 ()
[19] SYS SET_INT_VALUE    integer: int3, value: 1 (3)
[20] IF_INT_EQUAL:        compare: int1 with int3 ()
[21] BEGIN                ()
[22] ACT DO_SAY           oh hi mark (ch1)((null))
[23] MSG SEND_TO_ROOM_X   The mewlip executioner dodges out of the way of %s's attack. (ch1.room, ch2)
[24] MSG SEND_TO_CHAR     The mewlip executioner dodges out of the way of your attack. to: ch2 ((null))
[25] SYS RETURN_FALSE     
[26] END_ELSE_BEGIN       ()
[27] ACT DO_SAY           first (ch1)((null))
[28] END_ELSE_BEGIN       ()
[29] ACT DO_SAY           second (ch1)((null))
[30] END_ELSE_BEGIN       ()
[31] ACT DO_SAY           third (ch1)((null))
[32] END                  (10) ```
Dominant language
C++
Stars
3
Forks
4
Avg merge
18h 36m
Merged PRs (30d)
87

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from returnoftheshadow/RotS_Live

All issues in returnoftheshadow/RotS_Live

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.