Retrying an upload can fail in append-only mode
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- go
- Domain
- backend-api-design
Research direction
Start by reading the append-only upload behavior described here and the discussion in pull request #195, especially the referenced issue comment. No file or test is named, and the intended resolution is undecided between accepting a matching reupload and returning a special status code; done requires choosing and verifying one reliable retry behavior.
Written by the indexing model from the issue text.
Description
Output of rest-server --version
0.11.0
What should rest-server do differently?
As discussed in https://github.com/restic/rest-server/pull/195#issuecomment-1235918789 there is a possibility that retrying the upload for a file may fail in append-only mode:
if an upload for an append-only repository succeeds without the client learning about that fact, this will cause later retries to fail. It would be possible for the rest-server to accept a reupload iff that upload has the expected file hash.
Another option would be to return a special status code to signal to restic that the file in question already exists.
What are you trying to do? What is your use case?
Ensure uploads work reliably even when retries are necessary.
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 179
- Avg merge
- 15d 9h
- Merged PRs (30d)
- 2
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from restic/rest-server
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
restic/rest-server#389 ·
-
state: need feedback
Difficulty 3/5 1-2 days Newbie friendliness 55/100
restic/rest-server#391 · 5 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
restic/rest-server#390 · 1 comment · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
restic/rest-server#384 · 2 comments ·
-
Exit after configurable idle period for servers with limited RAM or are off/suspended when unusedOpen
Difficulty 4/5 3-5 days Newbie friendliness 50/100
restic/rest-server#383 · 2 comments ·
All issues in restic/rest-server
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
gruntwork-io/boilerplate#329 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
prime-radiant-inc/evener#3291 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Netcracker/qubership-apihub-backend#582 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day